Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup leftover "revoked" terminology from genesis and docs #2279

Closed
4 tasks
ValarDragon opened this issue Sep 8, 2018 · 2 comments · Fixed by #2337
Closed
4 tasks

Cleanup leftover "revoked" terminology from genesis and docs #2279

ValarDragon opened this issue Sep 8, 2018 · 2 comments · Fixed by #2337
Labels
C:x/staking T:Docs Changes and features related to documentation.

Comments

@ValarDragon
Copy link
Contributor

ValarDragon commented Sep 8, 2018 •
edited
Loading

Summary

In the genesis file we use "revoked", but in the code we use "jailed". It would be nice if we stuck with one term everywhere. I'm personally in favor of revoked.

/cc @rigelrozanski @cwgoes @alexanderbez

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@ValarDragon ValarDragon added T:Docs Changes and features related to documentation. C:x/staking labels Sep 8, 2018
@rigelrozanski
Copy link
Contributor

it's just remnants - revoked simply needs to be removed from the genesis - we've made the decision in previous conversations to switch to jailed: here #1879 and here #1305 (comment)

@rigelrozanski rigelrozanski changed the title Be more consistent with Jailed vs Revoked Cleanup leftover "revoked" terminology from genesis Sep 9, 2018
@ValarDragon
Copy link
Contributor Author

We also need to update the docs/spec. "Revoke" is used alot in there.

@rigelrozanski rigelrozanski changed the title Cleanup leftover "revoked" terminology from genesis Cleanup leftover "revoked" terminology from genesis and docs Sep 10, 2018
@ValarDragon ValarDragon mentioned this issue Sep 14, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C:x/staking T:Docs Changes and features related to documentation.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update revoked -> jailed in the docs, and in minor places within cmd. cosmos/cosmos-sdk
2 participants
@ValarDragon @rigelrozanski