Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Too much staking logic in app-simulation/genesis initialization #2449

Closed
rigelrozanski opened this issue Oct 5, 2018 · 3 comments
Closed

Comments

@rigelrozanski
Copy link
Contributor

During my investigation of simulation bugs due in introducing the distirbution module I realized the logic flow for staking is disembodied. A series of important hooks have recently been introduced into staking however, these hooks are not being properly called from the application, BECAUSE the application is actually performing some of the core staking logic for initialization. There needs to be a much clearer separation of concerns between staking and the app - there is a decent amount of code contained within:

cmd/gaia/app/sim_test.go
cmd/gaia/app/genesis.go 

should really be refactored from the app into staking, I noticed that some of what's happening in the app is actually duplicated code from staking! Anyways yeah this should be restored, so as new hooks and core functionality is expanded in staking, the app can take advantage by default rather than needing to have code updates itself

@cwgoes
Copy link
Contributor

cwgoes commented Oct 9, 2018

Ref #2452 (comment).

@rigelrozanski rigelrozanski added this to the Migrate Gaia out of the SDK repo milestone Apr 2, 2019
@rigelrozanski
Copy link
Contributor Author

dependant on #3006

@rigelrozanski rigelrozanski self-assigned this Apr 2, 2019
@rigelrozanski
Copy link
Contributor Author

closed by #4159

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants