Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

R4R: Various sign command improvements #2558

Merged
merged 19 commits into from
Oct 31, 2018
Merged

R4R: Various sign command improvements #2558

merged 19 commits into from
Oct 31, 2018

Conversation

alessio
Copy link
Contributor

@alessio alessio commented Oct 22, 2018 •
edited
Loading

  • Exit with error if the user is attempting to sign with a key whose address is not among those who are expected to sign the transaction.
  • Add --print-signature-only to output only the generated signature.
  • When --print-sigs is on, validate signatures order and report errors if there's any.
  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
  • Wrote tests
  • Updated relevant documentation (docs/)
  • Added entries in PENDING.md with issue #
  • rereviewed Files changed in the github PR explorer

For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@codecov
Copy link

codecov bot commented Oct 22, 2018 •
edited
Loading

Codecov Report

Merging #2558 into develop will decrease coverage by <.01%.
The diff coverage is 0%.

@@             Coverage Diff             @@
##           develop    #2558      +/-   ##
===========================================
- Coverage    58.84%   58.84%   -0.01%     
===========================================
  Files          152      152              
  Lines         9424     9425       +1     
===========================================
  Hits          5546     5546              
- Misses        3508     3509       +1     
  Partials       370      370

@alessio alessio changed the title Various sign command improvements R4R: Various sign command improvements Oct 23, 2018
alexanderbez
alexanderbez suggested changes Oct 23, 2018
View reviewed changes
Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alessio haven't gotten a chance to play with this yet, but I left some initial minor feedback.

x/auth/client/cli/sign.go Outdated
flagAppend = "append"
flagPrintSigs = "print-sigs"
flagOffline = "offline"
flagRawSignature = "raw-signature"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the diff between print-sigs and raw-signature? May I suggest renaming --raw-signature to --sig-only. Also, let's not jumble sig/s with signature/s. Let's stick to one.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I rename --raw-signature to --sig-only. Plus, I renamed --print-sigs to --validate-signatures.

x/auth/client/cli/sign.go Outdated Show resolved Hide resolved
@fedekunze
Copy link
Collaborator

@alessio let's add the new flags on docs/sdk/clients/.md

@alessio alessio requested a review from zramsay as a code owner October 25, 2018 03:44
cwgoes
cwgoes suggested changes Oct 25, 2018
View reviewed changes
Copy link
Contributor

@cwgoes cwgoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments.

x/auth/client/cli/sign.go Outdated Show resolved Hide resolved
x/auth/client/cli/sign.go Outdated Show resolved Hide resolved
x/auth/client/cli/sign.go Outdated Show resolved Hide resolved
x/auth/client/cli/sign.go Show resolved Hide resolved
alexanderbez
alexanderbez reviewed Oct 29, 2018
View reviewed changes
Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hate to be nit-picky here, but left some more minor feedback 👍

x/auth/client/cli/sign.go Outdated Show resolved Hide resolved
x/auth/client/cli/sign.go Outdated Show resolved Hide resolved
x/auth/client/cli/sign.go Outdated Show resolved Hide resolved
alexanderbez
alexanderbez approved these changes Oct 31, 2018
View reviewed changes
Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

testedACK -- thanks @alessio 🌵

cwgoes
cwgoes suggested changes Oct 31, 2018
View reviewed changes
Copy link
Contributor

@cwgoes cwgoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment.

x/auth/client/cli/sign.go Show resolved Hide resolved
@cwgoes cwgoes merged commit 8ae4761 into develop Oct 31, 2018
@cwgoes cwgoes deleted the alessio/sign-command branch October 31, 2018 18:56
@alessio alessio mentioned this pull request Dec 8, 2020
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fedekunze fedekunze fedekunze left review comments

@cwgoes cwgoes cwgoes approved these changes

@alexanderbez alexanderbez alexanderbez approved these changes

@ebuchman ebuchman Awaiting requested review from ebuchman

@rigelrozanski rigelrozanski Awaiting requested review from rigelrozanski

@jaekwon jaekwon Awaiting requested review from jaekwon

@zramsay zramsay Awaiting requested review from zramsay

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alessio @fedekunze @alexanderbez @cwgoes