Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch Governance ProposalIDs to be uint64 instead of int64 #2700

Closed
sunnya97 opened this issue Nov 5, 2018 · 2 comments
Closed

Switch Governance ProposalIDs to be uint64 instead of int64 #2700

sunnya97 opened this issue Nov 5, 2018 · 2 comments
Assignees
@sunnya97
Labels
C:x/gov Type: Code Hygiene General cleanup and restructuring of code to provide clarity, flexibility, and modularity.

Comments

@sunnya97
Copy link
Member

sunnya97 commented Nov 5, 2018

No reason is should ever be negative, so we should switch this.
@sunnya97 sunnya97 added C:x/gov Type: Code Hygiene General cleanup and restructuring of code to provide clarity, flexibility, and modularity. labels Nov 5, 2018
@sunnya97 sunnya97 self-assigned this Nov 5, 2018
@rigelrozanski
Copy link
Contributor

@sunnya97 have you checked with @jaekwon on this - seems to be contentious to be using uint :P

@sunnya97
Copy link
Member Author

sunnya97 commented Nov 9, 2018

Closed by #2638

@sunnya97 sunnya97 closed this as completed Nov 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sunnya97 sunnya97

Labels
C:x/gov Type: Code Hygiene General cleanup and restructuring of code to provide clarity, flexibility, and modularity.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sunnya97 @rigelrozanski