You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This is the implementation of getting sign bytes of CreateValidator msg:
// get the bytes for the message signer to sign onfunc (msgMsgCreateValidator) GetSignBytes() []byte {
b, err:=MsgCdc.MarshalJSON(struct {
DescriptionDelegatorAddr sdk.AccAddress`json:"delegator_address"`ValidatorAddr sdk.ValAddress`json:"validator_address"`PubKeystring`json:"pubkey"`Delegation sdk.Coin`json:"delegation"`
}{
Description: msg.Description,
ValidatorAddr: msg.ValidatorAddr,
PubKey: sdk.MustBech32ifyConsPub(msg.PubKey),
Delegation: msg.Delegation,
})
iferr!=nil {
panic(err)
}
returnsdk.MustSortJSON(b)
}
The above code location is here. This implementation does't include commission data into the sign bytes. I think this is improper.
Is there any special intention to leave commission data out?
The text was updated successfully, but these errors were encountered:
This is the implementation of getting sign bytes of CreateValidator msg:
The above code location is here. This implementation does't include commission data into the sign bytes. I think this is improper.
Is there any special intention to leave commission data out?
The text was updated successfully, but these errors were encountered: