Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Get* Prefixes from Key Construction Functions #2747

Closed
4 tasks done
alexanderbez opened this issue Nov 9, 2018 · 0 comments · Fixed by #6212
Closed
4 tasks done

Remove Get* Prefixes from Key Construction Functions #2747

alexanderbez opened this issue Nov 9, 2018 · 0 comments · Fixed by #6212
Labels
good first issue Type: Code Hygiene General cleanup and restructuring of code to provide clarity, flexibility, and modularity.

Comments

@alexanderbez
Copy link
Contributor

alexanderbez commented Nov 9, 2018 •
edited
Loading

Summary

The code is littered with functions such as GetValidatorSigningInfoAddress that compose keys for various store operations. As discussed offline, the Get* prefix semantics don't really make sense here as we're not operating on concrete types.

Proposal

Simply remove Get from said functions (e.g. GetValidatorSigningInfoAddress => ValidatorSigningInfoAddress).

/cc @jaekwon

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@alexanderbez alexanderbez added if-have-time prelaunch Type: Code Hygiene General cleanup and restructuring of code to provide clarity, flexibility, and modularity. labels Nov 9, 2018
@alexanderbez alexanderbez self-assigned this Nov 9, 2018
@alexanderbez alexanderbez removed their assignment Aug 30, 2019
@jackzampolin jackzampolin added this to the v0.38.0 milestone Sep 11, 2019
@alexanderbez alexanderbez removed this from the v0.38.0 milestone Oct 12, 2019
@kochetkov-av kochetkov-av mentioned this issue May 13, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Type: Code Hygiene General cleanup and restructuring of code to provide clarity, flexibility, and modularity.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove Get* Prefixes from Key Construction Functions kochetkov-av/cosmos-sdk
2 participants
@alexanderbez @jackzampolin