-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[R4R] Require moniker on gaiad init
#2773
Conversation
I'd rather make the flag required. It is a mandatory user input. |
@alessio I was leaning this way too. Ok 👌 |
Codecov Report
@@ Coverage Diff @@
## develop #2773 +/- ##
===========================================
+ Coverage 56.63% 56.65% +0.02%
===========================================
Files 156 156
Lines 9783 9783
===========================================
+ Hits 5541 5543 +2
+ Misses 3864 3863 -1
+ Partials 378 377 -1 |
gaiad init
gaiad init
gaiad init
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So I was able to run tests successfully here (make test
and make test_sim_gaia_multi_seed
), but when running gaiad init
with the built binary it doesn't require the flag and the command runs w/o requiring the flag.
@jackzampolin fixed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tACK
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TestedACK
closes: #2757
Targeted PR against correct branch (see CONTRIBUTING.md)
Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
Wrote tests
Updated relevant documentation (
docs/
)Added entries in
PENDING.md
with issue #rereviewed
Files changed
in the github PR explorerFor Admin Use: