-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
R4R: Update gas costs to more reasonable numbers for GoS #3052
Conversation
Would be cool to have 3 app-set constants, |
Sounds like it could be a good solution in the long run... the storage system should evolve to return some values upon operations that return the above kinds of values, and then compute the overall gas from those figures though, sounds useful. I'm not convinced that we need manage cpu costs, at least for the hub. |
Merging this in early for sake of release. Lets still discuss here though. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code changes look fine to me. We might want to set a non-zero default minimum fee for GoS.
|
||
// how much gas = 1 atom | ||
gasPerUnitCost = 1000 | ||
gasPerUnitCost = 10000 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is only efficacious if ctx.MinimumFees()
is nonzero, maybe we should set that for GoS
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How do we set this if it's set per validator? Simply state a recommendation?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just set a non-zero default. I think @zmanian will mention it in the docs, which works too
TODO: Create a new issue to unify gas constants in one place, and improve tests.
Recommended best-guess estimates for gas for GoS:
Targeted PR against correct branch (see CONTRIBUTING.md)
Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
Wrote tests
Updated relevant documentation (
docs/
)Added entries in
PENDING.md
with issue #rereviewed
Files changed
in the github PR explorer