Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

baseapp does not check block ordering #3790

Closed
ValarDragon opened this issue Mar 4, 2019 · 0 comments · Fixed by #3801
Closed

baseapp does not check block ordering #3790

ValarDragon opened this issue Mar 4, 2019 · 0 comments · Fixed by #3801

Comments

@ValarDragon
Copy link
Contributor

ValarDragon commented Mar 4, 2019

Baseapp currently gets the header height from the ABCI begin block request. It does not validate anywhere that this header height is non-negative, or that it equals previous height plus one, however this is an assumption we make within in the state machine. For improved safety as we start trying new underlying consensus algorithms, we should likely enforce this check within baseapp. (I did not check whether Tendermint enforces this, but I would assume that it does)

(Note that if we do things like proof of work with the SDK, handling histories and etc. would likely be the responsibility of Tendermint)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants