R4R: Make cli tests use build files #3808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackzampolin
reviewed
Mar 5, 2019
| @@ -160,8 +160,8 @@ godocs: | |||
|
|
|||
| test: test_unit | |||
|
|
|||
| test_cli: | |||
| @go test -p 4 `go list github.com/cosmos/cosmos-sdk/cmd/gaia/cli_test` -tags=cli_test | |||
| test_cli: build | |||
jackzampolin
reviewed
Mar 5, 2019
| @@ -163,7 +163,7 @@ func (f *Fixtures) Flags() string { | |||
|
|
|||
| // UnsafeResetAll is gaiad unsafe-reset-all | |||
| func (f *Fixtures) UnsafeResetAll(flags ...string) { | |||
| cmd := fmt.Sprintf("gaiad --home=%s unsafe-reset-all", f.GDHome) | |||
| cmd := fmt.Sprintf("../../../build/gaiad --home=%s unsafe-reset-all", f.GDHome) | |||
There was a problem hiding this comment.
I feel like this is something we should define on the Fixtures object (maybe gdcmd and gclicmd attributes) then it can be easily switched in and out for different usages (one example would be checking in NewFixtures if CI=true and directing to a previously built binary).
|
This localnet failure is due to not being able to pull the It sounds like this issue has been fixed. Kicking the tests. Great add @jaekwon! |
rigelrozanski
approved these changes
Mar 7, 2019
cwgoes
reviewed
Mar 7, 2019
Add PR number.
Codecov Report
@@ Coverage Diff @@
## develop #3808 +/- ##
===========================================
+ Coverage 60.88% 60.95% +0.07%
===========================================
Files 191 191
Lines 14180 14185 +5
===========================================
+ Hits 8633 8647 +14
+ Misses 4991 4984 -7
+ Partials 556 554 -2 |
cwgoes
approved these changes
Mar 7, 2019
jackzampolin
approved these changes
Mar 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.