Rejected proposal deposits shouldn't be burned

[fedekunze]

Summary of Bug

The DeleteDeposit should be renamed and the funds from rejected proposals should go to the community pool.

Quoting the whitepaper:

If more than half of the voters choose to take the deposit (e.g. because the proposal was spam), the deposit goes to the reserve pool, except any atoms which are burned.

Steps to Reproduce

See line 448:

cosmos-sdk/x/gov/keeper.go

Lines 438 to 455 in 21e0d3c

	// Deletes all the deposits on a specific proposal without refunding them
	func (keeper Keeper) DeleteDeposits(ctx sdk.Context, proposalID uint64) {
	store := ctx.KVStore(keeper.storeKey)
	depositsIterator := keeper.GetDeposits(ctx, proposalID)
	defer depositsIterator.Close()
	for ; depositsIterator.Valid(); depositsIterator.Next() {
	deposit := &Deposit{}
	keeper.cdc.MustUnmarshalBinaryLengthPrefixed(depositsIterator.Value(), deposit)
	// TODO: Find a way to do this without using accounts.
	err := keeper.ck.SendCoins(ctx, DepositedCoinsAccAddr, BurnedDepositCoinsAccAddr, deposit.Amount)
	if err != nil {
	panic("should not happen")
	}
	store.Delete(depositsIterator.Key())
	}
	}

cc: @alessio @sunnya97

---

For Admin Use

• Not duplicate issue
• Appropriate labels applied
• Appropriate contributors tagged
• Contributor assigned/self-assigned

Acceptance Criteria

AC1

Given a governance proposal
If the proposal is rejected
Then the existing Deposit (if any) amount should be transfer to the CommunityPool

AC2

Given a governance proposal P
Given P is rejected
When I query the CommunityPool using gaiacli q distr community-pool
Then it should return the updated amount of coins

AC3

Given a governance proposal P
Given P is rejected
When I query the CommunityPool using GET /distribution/community_pool
Then it should return the updated amount of coins

[alessio]

/cc @zmanian

[alexanderbez]

Per Zaki's suggestion, which I think is obvious, this should be implemented given the approval of a text governance proposal.

[fedekunze]

merged to master #4373