Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simulation: Allow Use of blocked Accounts #4915

Closed
3 of 4 tasks
alexanderbez opened this issue Aug 16, 2019 · 1 comment
Closed
3 of 4 tasks

Simulation: Allow Use of blocked Accounts #4915

alexanderbez opened this issue Aug 16, 2019 · 1 comment

Comments

@alexanderbez
Copy link
Contributor

alexanderbez commented Aug 16, 2019

During the introduction of the x/supply and as a result module accounts, we first found that we had to modify simulation to completely remove these module accounts from the list of all accounts.

Secondly, in the same light, we then realized that we also needed to modify certain modules (x/bank and x/distribution) to accept a series of blocked accounts to prevent funds from being sent to these accounts (which would break invariants).

I argue that we should instead allow simulation to use these blocked accounts (to a degree). If we had done so, #4912 would've been caught by simulation before the v0.36 release! This is a section state space we still want to test by simulation!

Obviously, we still want to prohibit these module accounts from being validators or being involved in staking, so I propose we somehow modify the existing simulation to allow x/bank and x/distribution to use these accounts.

/cc @AdityaSripal @colin-axner @fedekunze


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@github-actions
Copy link
Contributor

github-actions bot commented Jul 8, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Jul 8, 2020
@fedekunze fedekunze changed the title Simulation: Allow Use of Blacklisted Accounts Simulation: Allow Use of blocked Accounts Jul 8, 2020
@tac0turtle tac0turtle closed this as not planned Won't fix, can't repro, duplicate, stale Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants