You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
During the introduction of the x/supply and as a result module accounts, we first found that we had to modify simulation to completely remove these module accounts from the list of all accounts.
Secondly, in the same light, we then realized that we also needed to modify certain modules (x/bank and x/distribution) to accept a series of blocked accounts to prevent funds from being sent to these accounts (which would break invariants).
I argue that we should instead allow simulation to use these blocked accounts (to a degree). If we had done so, #4912 would've been caught by simulation before the v0.36 release! This is a section state space we still want to test by simulation!
Obviously, we still want to prohibit these module accounts from being validators or being involved in staking, so I propose we somehow modify the existing simulation to allow x/bank and x/distribution to use these accounts.
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
During the introduction of the
x/supply
and as a result module accounts, we first found that we had to modify simulation to completely remove these module accounts from the list of all accounts.Secondly, in the same light, we then realized that we also needed to modify certain modules (
x/bank
andx/distribution
) to accept a series of blocked accounts to prevent funds from being sent to these accounts (which would break invariants).I argue that we should instead allow simulation to use these blocked accounts (to a degree). If we had done so, #4912 would've been caught by simulation before the v0.36 release! This is a section state space we still want to test by simulation!
Obviously, we still want to prohibit these module accounts from being validators or being involved in staking, so I propose we somehow modify the existing simulation to allow
x/bank
andx/distribution
to use these accounts./cc @AdityaSripal @colin-axner @fedekunze
For Admin Use
The text was updated successfully, but these errors were encountered: