Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Internal from Module Spec + Update Modules #5646

Closed
7 of 9 tasks
alexanderbez opened this issue Feb 14, 2020 · 0 comments · Fixed by #5745
Closed
7 of 9 tasks

Remove Internal from Module Spec + Update Modules #5646

alexanderbez opened this issue Feb 14, 2020 · 0 comments · Fixed by #5745
Assignees
Labels
T: Dev UX UX for SDK developers (i.e. how to call our code) T:Docs Changes and features related to documentation.

Comments

@alexanderbez
Copy link
Contributor

alexanderbez commented Feb 14, 2020

As a result of #5533, the module pattern of internal no longer serves our needs. This is primarily due to the following:

  • Needing access to types.proto. We cannot get access to these message definitions if they're in internal/.
  • We've done a great job of testing cleanup (e.g. removing x/mock) so that there is less dependency hell.
  • We end up aliasing 90+% of the module anyway.

So the only "win" of internal/ is simply developer UX of not needing to import multiple packages. However, this is moot as any basic IDE should auto-import for you.

  • x/bank
  • x/crisis
  • x/evidence
  • x/mint
  • x/upgrade

/cc @fedekunze @marbar3778 @jackzampolin @hschoenburg


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@alexanderbez alexanderbez added T:Docs Changes and features related to documentation. T: Dev UX UX for SDK developers (i.e. how to call our code) labels Feb 14, 2020
@alexanderbez alexanderbez changed the title Update Module Spec + Modules Remove Internal from Module Spec + Update Modules Feb 14, 2020
@clevinson clevinson added this to the v0.39 milestone Apr 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T: Dev UX UX for SDK developers (i.e. how to call our code) T:Docs Changes and features related to documentation.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants