Standarize deposit representation in governance proposal files

[sunnya97]

Different Proposal type files represent deposits differently.

For example, Text Proposals have use the string version of an sdk.Coin (i.e. 10uatom) while ParamChange Proposals use the JSON version (i.e. { "denom": "stake", "amount": "10000"})

https://github.com/cosmos/cosmos-sdk/blob/master/x/gov/client/cli/tx.go#L92

https://github.com/cosmos/cosmos-sdk/blob/master/x/params/client/cli/tx.go#L44

---

For Admin Use

• Not duplicate issue
• Appropriate labels applied
• Appropriate contributors tagged
• Contributor assigned/self-assigned

[jgimeno]

I think makes more sense the second version, more accurate.

{ "denom": "stake", "amount": "10000"}

The only problem I see is in cases like this:

{
  "title": "Test Proposal",
  "description": "My awesome proposal",
  "type": "Text",
  "deposit": "10test"
}

Which is equivalent to:

$ %s tx gov submit-proposal --title="Test Proposal" --description="My awesome proposal" --type="Text" --deposit="10test" --from mykey

Where the equivalent flag is --deposit="10test", in that case looks like the denom+amount would make the alternate version different.

So maybe is easier to use the short version. Any thoughts on this?

[sunnya97]

I have a slight preference towards the first one (the string version). Most of the places in our user flow that users have to use sdk.Coins, they use the string version.

But on the other hand, we typically use the JSON version, in JSONs (like the genesis file for example).

I guess it depends what the expected way of creating proposal files is. Do we expect people to write them by hand, or are they supposed to be the output of some Proposal Generation tool?

[jgimeno]

What about on every JSON always:

{ "denom": "stake", "amount": "10000"}

but on command line the short one, and convert to json version behind the scenes when needed.

[alexanderbez]

I recommend to take string which is comma delimited and call ParseCoins instead of JSON. This makes client logic and parsing easier.