Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove DefaultParamspace #6562

Closed
4 tasks
jgimeno opened this issue Jul 1, 2020 · 1 comment · Fixed by #6564
Closed
4 tasks

Remove DefaultParamspace #6562

jgimeno opened this issue Jul 1, 2020 · 1 comment · Fixed by #6564
Labels
S:proposed T: Dev UX UX for SDK developers (i.e. how to call our code)

Comments

@jgimeno
Copy link
Contributor

jgimeno commented Jul 1, 2020

Summary

The constant per module for the DefaultParamspace is always set to ModuleName.

Problem Definition

I don't see any benefit of using the constant but to use ModuleName instead.

Proposal

Remove all DefaultParamspace so the code is cleaner.

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@jgimeno jgimeno added S:proposed T: Dev UX UX for SDK developers (i.e. how to call our code) labels Jul 1, 2020
@jgimeno jgimeno mentioned this issue Jul 1, 2020
Merged
9 tasks
@alexanderbez
Copy link
Contributor

Agreed. Feel free to tackle this since it seems quick to do.

@mergify mergify bot closed this as completed in #6564 Jul 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
S:proposed T: Dev UX UX for SDK developers (i.e. how to call our code)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove DefaultParamspace and simplify simapp creation. cosmos/cosmos-sdk
2 participants
@jgimeno @alexanderbez