Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UX: improve [gaiacli keys] #674

Closed
2 tasks
zramsay opened this issue Mar 20, 2018 · 5 comments
Closed
2 tasks

UX: improve [gaiacli keys] #674

zramsay opened this issue Mar 20, 2018 · 5 comments
Labels

Comments

@zramsay
Copy link
Contributor

zramsay commented Mar 20, 2018

  • the requirement to use names (--name) should be removed. It's fine as a helper but right now it's super confusing. I should be able to do basecli keys add --new and just get an un-named key. The only output should be the address to stdout (maybe in combination with a --dev flag). The extra stuff like text and recovery phrase outputted to stdout is clutter for automated tests.
  • re-introduce the --from flag for basecli keys send. This flag IIRC once existed. Sending a transaction should have a --from and a --to. Even if the --name flag is well described (it currently isn't), using --name as the "from" is wholly unintuitive.
@jaekwon
Copy link
Contributor

jaekwon commented Apr 15, 2018

I think basecli keys shouldn't know about tx formats. You should generate the bytes to sign, and sign it as a separate step using basecli keys.

@cwgoes cwgoes added this to the 1.0 Code Freeze milestone Apr 27, 2018
@zramsay zramsay changed the title modifications to [basecli keys] UX: improve [gaiacli keys] May 18, 2018
@ValarDragon
Copy link
Contributor

We should also include more information for people trying to specify the recovery key themselves. (i.e. what the wordlist is, minimum number of words, etc.)

@ValarDragon
Copy link
Contributor

Is requiring --name a big problem for automation scripts? It didn't appear to me to be too bad in the CLI tests, and its something we want to enforce onto most users.

@ValarDragon
Copy link
Contributor

ValarDragon commented Jul 5, 2018

For gaiacli send, here is what I am thinking for changing --name to --from. I think we should have some code duplication in gaia-7000, and support both --name and --from, but provide a warning whenever a user uses --name instead of --from. Update all the docs to not mention --from anymore, and make the help note that its deprecated. (The purpose of this deprecation is to make the transition less painful for people) Overall, I think transitioning like this will save a lot of problems on our end regarding communicating this breaking change, since gaia-7000 users will see the warning when using the code.

Then once gaia-7000 is merged remove the code supporting --name.

@jackzampolin
Copy link
Member

Closing this as fix was merged with #1568

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants