Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create test for returning non-empty app_hash from InitChain #7283

Closed
4 tasks
amaury1093 opened this issue Sep 11, 2020 · 1 comment
Closed
4 tasks

Create test for returning non-empty app_hash from InitChain #7283

amaury1093 opened this issue Sep 11, 2020 · 1 comment
Labels

Comments

@amaury1093
Copy link
Contributor

amaury1093 commented Sep 11, 2020

Summary

Create a meaningful test for returning app_hash from InitChain after an upgrade

Problem Definition

After #7020 & #7208, InitChain returns the app_hash to Tendermint.

For a fresh chain, the app_hash is sha256(""). This use case is tested.
For an upgrade, app_hash is the last commitID. This use case is not tested.

Proposal

Add a test case (ideally an integration test) that would look like:

  • launch a chain
  • wait a couple of blocks
  • stop the chain, do an upgrade
  • run the upgraded chain (with same store)
  • expected: the upgraded chain should call InitChain, and return the last commitID of the store.

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@tac0turtle
Copy link
Member

closing this as it will be done in v2

@github-project-automation github-project-automation bot moved this from 📋 Backlog to 🥳 Done in Cosmos-SDK Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: 🥳 Done
Development

No branches or pull requests

3 participants