state-sync: enable snapshotting by default

[tac0turtle]

Summary

Currently, snapshotting is defaulted to off. While testing stargate-2 I had to stop and start my running node in order to enable this setting, and I had to sync a second node because people were not aware they had to turn this feature on.

Problem Definition

State-sync will not be able to be used if not on by default

Proposal

Turn snapshotting on by default.

The second part would be to make it worth with the application pruning setting. It will be hard to inform people to keep these in sync.

---

For Admin Use

• Not duplicate issue
• Appropriate labels applied
• Appropriate contributors tagged
• Contributor assigned/self-assigned

[alexanderbez]

#7166 (comment) This was intentional and you were part of that discussion. I think the idea was that we keep it disabled until it has been battle-tested.

[tac0turtle]

Hmm will close this issue but how is it suppose to get battle tested if one needs to turn it on but no one knows this.

[alexanderbez]

By documentation and marketing it. You don't do it by blindly enabling it in case it has issues.

[tac0turtle]

Hopefully we can move forward by simple default. I just spent an hour or so debugging a users state sync setup only to find no nodes in the stargate testnet had snapshotting enabled.