Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup keys.go in 24-host #7710

Closed
4 tasks
colin-axner opened this issue Oct 28, 2020 · 1 comment
Closed
4 tasks

Cleanup keys.go in 24-host #7710

colin-axner opened this issue Oct 28, 2020 · 1 comment
Labels
T: Dev UX UX for SDK developers (i.e. how to call our code)

Comments

@colin-axner
Copy link
Contributor

Summary

During audit we noted the readability of keys.go could be improved. There were some unused functions and some constants in the file were not using a constant variable. We should always use consts and vars instead of hardcoded strings.

Key and Path functions are used for string vs byte representation. We should try to remove one of the functions if minimally used in the codebase to improve readability.


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@colin-axner colin-axner added the T: Dev UX UX for SDK developers (i.e. how to call our code) label Oct 28, 2020
@colin-axner colin-axner self-assigned this Oct 28, 2020
@colin-axner
Copy link
Contributor Author

Ideally this comment is addressed too.

I think the functions could be renamed from KeyClientState to ClientStateKey etc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T: Dev UX UX for SDK developers (i.e. how to call our code)
Projects
None yet
Development

No branches or pull requests

1 participant