Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HD path from BIP44 doesn't match Ethereum's #7966

Closed
4 tasks
fedekunze opened this issue Nov 18, 2020 · 1 comment · Fixed by #7970
Closed
4 tasks

HD path from BIP44 doesn't match Ethereum's #7966

fedekunze opened this issue Nov 18, 2020 · 1 comment · Fixed by #7970
Labels
T:Bug

Comments

@fedekunze
Copy link
Collaborator

Summary of Bug

A user reported cosmos/ethermint#605 on Ethermint. The main discrepancy between the two implementations is the lack of the m/ prefix on the Bip44 String() function.

This inconsistency affects the launchpad and stargate series.

cc: @alessio @robert-zaremba @alexanderbez @aaronc

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@fedekunze
Copy link
Collaborator Author

q: would we have to migrate the addresses if we patch this?

@fedekunze fedekunze mentioned this issue Nov 18, 2020
Merged
@mergify mergify bot closed this as completed in #7970 Nov 18, 2020
@alessio alessio mentioned this issue Nov 19, 2020
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
T:Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

crypto/hd: add 'm/' prefix to hd path cosmos/cosmos-sdk
2 participants
@alessio @fedekunze