Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Connection-Delay Period #7983

Closed
AdityaSripal opened this issue Nov 19, 2020 · 1 comment · Fixed by #8069
Closed

Create Connection-Delay Period #7983

AdityaSripal opened this issue Nov 19, 2020 · 1 comment · Fixed by #8069
Assignees

Comments

@AdityaSripal
Copy link
Member

AdityaSripal commented Nov 19, 2020

Create Packet-specified Delay period that ensures that a delayPeriod amount of time has passed between the creation of a consensus state and when it can be used for verification of the packet functions (recv/ack/timeout). This ensures that there is at least some time available for a relayer to submit Misbehaviour and invalidate the consensus state before it gets used to process this packet.

Since different users may have different tolerances for risk, we allow it to be defined at packet-level so all users may use a single client while still choosing their own level of risk-tolerance with regards to race conditions between their packet getting processed and potential misbehaviour-submission.

NOTE: The above proposal was found to be insecure since an attacker could simply forge a packet with a 0 delay period. The delay period is specified at the connection-level, fixed at the start of the handshake. Modules that are transferring packets with value must take care to properly separate liquidity pools into the channels that they originated from.

@AdityaSripal AdityaSripal self-assigned this Nov 19, 2020
@AdityaSripal AdityaSripal linked a pull request Nov 19, 2020 that will close this issue
11 tasks
@colin-axner
Copy link
Contributor

see comment. Further discussion will likely occur on the ICS repo

@AdityaSripal AdityaSripal changed the title Create Packet-Delay Period Create Connection-Delay Period Dec 3, 2020
@mergify mergify bot closed this as completed in #8069 Dec 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants