Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include make proto-dev-all command #8021

Closed
AdityaSripal opened this issue Nov 24, 2020 · 1 comment · Fixed by #7852
Closed

Include make proto-dev-all command #8021

AdityaSripal opened this issue Nov 24, 2020 · 1 comment · Fixed by #7852
Labels
good first issue T: Dev UX UX for SDK developers (i.e. how to call our code)

Comments

@AdityaSripal
Copy link
Member

Everytime I use the proto make commands is because I've changed some proto definition. This makes it impossible for me to use make proto-all because it runs proto-check-breaking, and this always returns an error if I'm touching proto files.

So I usually run all the commands in make proto-all except for check breaking individually, this is a bit annoying and makes it likely for me or others to miss a command. I propose we add a command:

make proto-dev-all that will do everything that make proto-all does without doing proto-check-breaking.

@AdityaSripal AdityaSripal added T: Dev UX UX for SDK developers (i.e. how to call our code) good first issue labels Nov 24, 2020
@amaury1093
Copy link
Contributor

amaury1093 commented Nov 27, 2020

We could also remove proto-check-breaking from proto-all. make proto-all was meant to be used manually by devs, your use case makes sense (and anyways,proto-check-breaking is only relevant on CI). Happy to review the PR if you create one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue T: Dev UX UX for SDK developers (i.e. how to call our code)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants