You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Everytime I use the proto make commands is because I've changed some proto definition. This makes it impossible for me to use make proto-all because it runs proto-check-breaking, and this always returns an error if I'm touching proto files.
So I usually run all the commands in make proto-all except for check breaking individually, this is a bit annoying and makes it likely for me or others to miss a command. I propose we add a command:
make proto-dev-all that will do everything that make proto-all does without doing proto-check-breaking.
The text was updated successfully, but these errors were encountered:
We could also remove proto-check-breaking from proto-all. make proto-all was meant to be used manually by devs, your use case makes sense (and anyways,proto-check-breaking is only relevant on CI). Happy to review the PR if you create one.
Everytime I use the proto make commands is because I've changed some proto definition. This makes it impossible for me to use
make proto-all
because it runsproto-check-breaking
, and this always returns an error if I'm touching proto files.So I usually run all the commands in
make proto-all
except for check breaking individually, this is a bit annoying and makes it likely for me or others to miss a command. I propose we add a command:make proto-dev-all
that will do everything thatmake proto-all
does without doingproto-check-breaking
.The text was updated successfully, but these errors were encountered: