Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use auto generated client identifiers #8032

Closed
4 tasks done
colin-axner opened this issue Nov 26, 2020 · 0 comments · Fixed by #8034
Closed
4 tasks done

Use auto generated client identifiers #8032

colin-axner opened this issue Nov 26, 2020 · 0 comments · Fixed by #8034

Comments

@colin-axner
Copy link
Contributor

colin-axner commented Nov 26, 2020

Summary

proposal by @AdityaSripal

Use auto generated client identifiers. During create client a client identifier will created using a global counter stored in the 02-client keeper. The identifier will take the format <clientType>-<counter. For example:

tendermint-1
solomachine-2
tendermint-v2-3

The addition of the client type is for UI purposes, the counter provides the uniqueness we require for security. This will not require an ICS change as it will be specific to the SDK IBC implementation.

This aligns the architecture with how we construct connection/channel identifiers, lowers the burden of UX complexity on the relayer and prevents poor design choices by making the identifiers explicitly meaningless.


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant