Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove client/keys.KeysCdc #8047

Closed
4 tasks
robert-zaremba opened this issue Nov 30, 2020 · 1 comment · Fixed by #13781
Closed
4 tasks

Remove client/keys.KeysCdc #8047

robert-zaremba opened this issue Nov 30, 2020 · 1 comment · Fixed by #13781
Labels
C:Encoding T:tech debt Tech debt that should be cleaned up Type: Code Hygiene General cleanup and restructuring of code to provide clarity, flexibility, and modularity.
Milestone
Feature Backlog

Comments

@robert-zaremba
Copy link
Collaborator

robert-zaremba commented Nov 30, 2020 •
edited
Loading

Summary

client/keys.KeysCdc is used only in CLI display functions and tests and exposes an API which shouldn't be used.

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@robert-zaremba robert-zaremba self-assigned this Nov 30, 2020
@robert-zaremba robert-zaremba mentioned this issue Nov 30, 2020
Closed
9 tasks
@amaury1093 amaury1093 added Type: Code Hygiene General cleanup and restructuring of code to provide clarity, flexibility, and modularity. C:Encoding labels Dec 1, 2020
@robert-zaremba
Copy link
Collaborator Author

@aaronc , @clevinson , the KeyCdc *LegacyAmino is used in printKeyInfo and displayParseKeyInfo CLI functions.

Do you think it will be all right to finally migrate to sdkContext.Codec to complete this task?

@tac0turtle tac0turtle added the T:tech debt Tech debt that should be cleaned up label Oct 21, 2022
@jacobhjkim jacobhjkim mentioned this issue Nov 7, 2022
Merged
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C:Encoding T:tech debt Tech debt that should be cleaned up Type: Code Hygiene General cleanup and restructuring of code to provide clarity, flexibility, and modularity.
Projects
No open projects
Cosmos SDK Maintenance
Status: Done
Milestone
Feature Backlog
Development

Successfully merging a pull request may close this issue.

refactor: Remove client/keys.KeysCdc
5 participants
@robert-zaremba @clevinson @amaury1093 @tac0turtle @technicallyty