Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor fee_grant AnteHandler to x/auth #8611

Closed
clevinson opened this issue Feb 17, 2021 · 1 comment · Fixed by #8682
Closed

Refactor fee_grant AnteHandler to x/auth #8611

clevinson opened this issue Feb 17, 2021 · 1 comment · Fixed by #8682
Assignees
Milestone

Comments

@clevinson
Copy link
Contributor

We shouldn't be maintaining two separate antehandler chains.

Ideally the x/fee_grant antehandler chain should be migrated over to x/auth AnteHandler chain.

@aaronc
Copy link
Member

aaronc commented Feb 18, 2021

And if fee grant isn't in the AnteHandler constructor then we don't include it's AnteDecorator.

We may want to consider migrating to an AnteHandlerBuilder type rather than adding more positional parameters to the ante handler constructor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants