Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document usage of ' in events #8736

Closed
7 tasks
amaury1093 opened this issue Mar 1, 2021 · 0 comments · Fixed by #8895
Closed
7 tasks

Document usage of ' in events #8736

amaury1093 opened this issue Mar 1, 2021 · 0 comments · Fixed by #8895
Assignees
Labels
C: gRPC Issues and PRs related to the gRPC service and HTTP gateway. T:Docs Changes and features related to documentation.

Comments

@amaury1093
Copy link
Contributor

amaury1093 commented Mar 1, 2021

Summary

We should explicity state that events require a '

Problem Definition

It's not clear whether we should do message.action=send or message.action='send'.

Before #8734, if we sent a gRPC request with message.action=send, the handler automatically added ' to convert to message.action='send'.

It has been removed in #8734, because it's probably more confusing than helpful. Tendermint always expect ', so we should just follow what TM does.

Proposal


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: gRPC Issues and PRs related to the gRPC service and HTTP gateway. T:Docs Changes and features related to documentation.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant