Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing for inplace store migrations #9069

Closed
4 tasks
sahith-narahari opened this issue Apr 7, 2021 · 2 comments
Closed
4 tasks

Testing for inplace store migrations #9069

sahith-narahari opened this issue Apr 7, 2021 · 2 comments

Comments

@sahith-narahari
Copy link
Contributor

Summary

We need a way to test migrate functions are in sync with latest codebase.

Problem Definition

It is currently possible that changes are made to the codebase but migration scripts weren't updated based on new changes.
This causes migrations to fail during upgrade. Currently we have to test this manually to ensure upgrades aren't broken

Proposal

It would be nice to have a way to test this using cosmovisor. We can have binary of an older version of simapp in cosmovisor/testdata and use it to upgrade the chain to a latest version based on master. This should ensure migrations aren't broken.


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@amaury1093
Copy link
Contributor

Thanks @sahith-narahari! I did a manual upgrade once and found some bugs that were not caught/catchable by the SDKs integration tests. So definitely a +1 for cosmovisor tests 👍

@tac0turtle
Copy link
Member

we have this via system tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants