ABCI query should use Request Height not Context height in setting query height

[colin-axner]

Summary

ABCI query should use the request height not the context height

Related to: 7ba386f

Problem Definition

The current ABCI query sets the opts to use a height from the context height. From my understanding, this is incorrect behaviour. It should use req.Height in the same way it uses req.Prove to set the Prove value for ABCIQueryWithOptions. I believe the current request height value is unused, which is misleading.

This lead to a bug in the helper function exposed from the IBC module. It set the request height correctly, but the context height was incorrectly set (since it was never assumed to be used)

Proposal

Change to use req.Height. This may have implications for dependencies which rely on the context height instead of the request height

---

For Admin Use

• Not duplicate issue
• Appropriate labels applied
• Appropriate contributors tagged
• Contributor assigned/self-assigned

[alexanderbez]

Your reasoning sounds correct to me 👍

[robert-zaremba]

oh, so we were always responding based on the "latest" state, not the requested state?

[alexanderbez]

I believe we were always using the Context's height, which when zero, uses the latest height/state. However, when a specific height is requested, I don't think it worked in specific query paths. Correct me if I'm wrong @colin-axner

[colin-axner]

I believe we were always using the Context's height, which when zero, uses the latest height/state. However, when a specific height is requested, I don't think it worked in specific query paths.

This is correct. The height field in the request was unused and it instead relied solely on the context height