Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove param module from x/crisis #12445

Closed
2 tasks
Tracked by #10514
atheeshp opened this issue Jul 5, 2022 · 0 comments · Fixed by #12491
Closed
2 tasks
Tracked by #10514

remove param module from x/crisis #12445

atheeshp opened this issue Jul 5, 2022 · 0 comments · Fixed by #12491
Assignees
@atheeshp

Comments

@atheeshp
Copy link
Contributor

atheeshp commented Jul 5, 2022

  • remove dependence on param module
  • write param module to module store migration
@atheeshp atheeshp changed the title remove param module from x/distribution remove param module from x/crisis Jul 5, 2022
@atheeshp atheeshp self-assigned this Jul 5, 2022
This was referenced Jul 5, 2022
Closed
Merged
@tac0turtle tac0turtle moved this to 📝 Todo in Cosmos-SDK Jul 9, 2022
@tac0turtle tac0turtle moved this from 📝 Todo to 👀 Needs Review in Cosmos-SDK Jul 11, 2022
@mergify mergify bot closed this as completed in #12491 Jul 12, 2022
mergify bot pushed a commit that referenced this issue Jul 12, 2022
@atheeshp
feat: remove x/params dependency in x/crisis (#12491)
7c1d743 
## Description

Closes: #12445 



---

### Author Checklist

*All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.*

I have...

- [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] added `!` to the type prefix if API or client breaking change
- [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#pr-targeting))
- [ ] provided a link to the relevant issue or specification
- [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/main/docs/building-modules)
- [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#testing)
- [ ] added a changelog entry to `CHANGELOG.md`
- [ ] included comments for [documenting Go code](https://blog.golang.org/godoc)
- [ ] updated the relevant documentation or specification
- [ ] reviewed "Files changed" and left comments if necessary
- [ ] confirmed all CI checks have passed

### Reviewers Checklist

*All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.*

I have...

- [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] confirmed `!` in the type prefix if API or client breaking change
- [ ] confirmed all author checklist items have been addressed 
- [ ] reviewed state machine logic
- [ ] reviewed API design and naming
- [ ] reviewed documentation is accurate
- [ ] reviewed tests and test coverage
- [ ] manually tested (if applicable)
Repository owner moved this from 👀 Needs Review to 👏 Done in Cosmos-SDK Jul 12, 2022
@atheeshp atheeshp mentioned this issue Jul 12, 2022
Merged
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@atheeshp atheeshp

Labels
None yet
Projects
Cosmos-SDK
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: remove x/params dependency in x/crisis cosmos/cosmos-sdk
2 participants
@tac0turtle @atheeshp