From b558e50eb28b3a76124ab5c6ceb400b38f57b5a5 Mon Sep 17 00:00:00 2001 From: Jack Zampolin Date: Fri, 7 Dec 2018 17:33:52 -0800 Subject: [PATCH 1/2] Fix quoted json return --- client/keys/list.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/client/keys/list.go b/client/keys/list.go index f232fccffb9d..9d01d500bb91 100644 --- a/client/keys/list.go +++ b/client/keys/list.go @@ -50,7 +50,7 @@ func QueryKeysRequestHandler(indent bool) http.HandlerFunc { } // an empty list will be JSONized as null, but we want to keep the empty list if len(infos) == 0 { - PostProcessResponse(w, cdc, "[]", indent) + PostProcessResponse(w, cdc, []string{}, indent) return } keysOutput, err := Bech32KeysOutput(infos) From be98f77aee148921ae5dd00cdfdcf6952ee11ada Mon Sep 17 00:00:00 2001 From: Jack Zampolin Date: Fri, 7 Dec 2018 18:02:18 -0800 Subject: [PATCH 2/2] Add pending --- PENDING.md | 1 + 1 file changed, 1 insertion(+) diff --git a/PENDING.md b/PENDING.md index 73567c237303..3be49eeb0b0e 100644 --- a/PENDING.md +++ b/PENDING.md @@ -3,6 +3,7 @@ BREAKING CHANGES * Gaia REST API (`gaiacli advanced rest-server`) + * [lcd] https://github.com/cosmos/cosmos-sdk/pull/3045 Fix quoted json return on GET /keys (keys list) * Gaia CLI (`gaiacli`) * [cli] [\#2595](https://github.com/cosmos/cosmos-sdk/issues/2595) Remove `keys new` in favor of `keys add` incorporating existing functionality with addition of key recovery functionality.