Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All gRPC tests should use new testing package #143

Closed
2 of 3 tasks
colin-axner opened this issue Apr 28, 2021 · 2 comments · Fixed by #3227
Closed
2 of 3 tasks

All gRPC tests should use new testing package #143

colin-axner opened this issue Apr 28, 2021 · 2 comments · Fixed by #3227
Labels
good first issue Good for newcomers testing Testing package and unit/integration tests

Comments

@colin-axner
Copy link
Contributor

colin-axner commented Apr 28, 2021

Summary

In #140 I noticed some gRPC tests were not using the new testing package. The test case that req = nil can only be tested with the new testing package. We should update all tests and remove any old testing code for this setup. It is much easier to maintain the new testing code


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@colin-axner colin-axner added the testing Testing package and unit/integration tests label Apr 28, 2021
@colin-axner colin-axner added this to the 1.1.0 milestone May 10, 2021
@crodriguezvega crodriguezvega modified the milestones: 1.1.0, vNext Sep 17, 2021
@crodriguezvega crodriguezvega removed this from the Q2-2022-backlog milestone Mar 31, 2022
@crodriguezvega
Copy link
Contributor

crodriguezvega commented Feb 25, 2023

I think the idea would be to get rid of queryClient field in the test suites for:

And call instead the gRPC endpoint using the method in the keeper. For example: for transfer instead of doing suite.queryClient.DenomTrace, call suite.chainA.GetSimApp().TransferKeeper.DenomTrace.

@crodriguezvega crodriguezvega added the good first issue Good for newcomers label Feb 25, 2023
@expertdicer expertdicer mentioned this issue Mar 2, 2023
9 tasks
@expertdicer
Copy link
Contributor

Can you please review my changes? Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers testing Testing package and unit/integration tests
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants