Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Emit more information in connection and channel handshake #147

Closed
3 tasks
colin-axner opened this issue Apr 29, 2021 · 2 comments
Closed
3 tasks

Emit more information in connection and channel handshake #147

colin-axner opened this issue Apr 29, 2021 · 2 comments
Assignees
@colin-axner
Milestone
1.0.0

Comments

@colin-axner
Copy link
Contributor

colin-axner commented Apr 29, 2021 •
edited
Loading

Summary

Versions are not emitted in either case. This information may be useful to relayers, especially in the application case where off-chain negotiation is expected.

These versions will need to be hex encoded (for now, see #144 )

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@colin-axner
Copy link
Contributor Author

We should just emit the proto encoded connection/channel (hex encoded as well)

@colin-axner colin-axner self-assigned this Apr 29, 2021
@colin-axner colin-axner added this to the 1.0.1 milestone Apr 29, 2021
@colin-axner
Copy link
Contributor Author

Discussed with @AdityaSripal and this seems unnecessary since the information can always be queried

@crodriguezvega crodriguezvega modified the milestones: 1.1.0, 1.0.0 Sep 17, 2021
faddat referenced this issue in notional-labs/ibc-go Feb 23, 2022
@ethanfrey
Merge pull request #147 from CosmWasm/update-cosmwasm
1fd9192 
Update cosmwasm
faddat referenced this issue in notional-labs/ibc-go Mar 1, 2022
Merge PR #147: ADD chain
1bb540d 
* ADD chain

* correct sed stake in genesis.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@colin-axner colin-axner

Labels
None yet
Projects
None yet
Milestone
1.0.0
Development

No branches or pull requests
2 participants
@crodriguezvega @colin-axner