Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Solomachine ZeroCustomFields should not modify IsFrozen #1885

Closed
3 tasks
colin-axner opened this issue Aug 4, 2022 · 0 comments · Fixed by #1972
Closed
3 tasks

Solomachine ZeroCustomFields should not modify IsFrozen #1885

colin-axner opened this issue Aug 4, 2022 · 0 comments · Fixed by #1972
Assignees
@seantking
Labels
06-solomachine
Milestone
02-client refacto...

Comments

@colin-axner
Copy link
Contributor

Summary

ZeroCustomFields should use the ClientState{} type rather than NewClientState() to ensure the IsFrozen field is not modified. Low priority, shouldn't change anything as ZeroCustomFields isn't used for solo machine

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@colin-axner colin-axner mentioned this issue Aug 4, 2022
Merged
9 tasks
@seantking seantking self-assigned this Aug 5, 2022
@crodriguezvega crodriguezvega moved this to In progress in ibc-go Aug 5, 2022
@crodriguezvega crodriguezvega added this to the 02-client refactor beta milestone Aug 5, 2022
@seantking seantking mentioned this issue Aug 10, 2022
Merged
9 tasks
Repository owner moved this from In progress to Done in ibc-go Aug 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@seantking seantking

Labels
06-solomachine
Projects
ibc-go
Archived in project
Milestone
02-client refactor beta
Development

Successfully merging a pull request may close this issue.

refactor: panic on ZeroCustomFields for solo machine implementation cosmos/ibc-go
3 participants
@crodriguezvega @seantking @colin-axner