e2e: fee middleware with multiple incentivisers #2073
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charleenfei
requested review from
colin-axner,
AdityaSripal,
crodriguezvega,
seantking,
damiannolan and
chatton
as code owners
chatton
approved these changes
Aug 23, 2022
Comment on lines
+703
to
+704
| actualFee1 := packets[0].PacketFees[0].Fee | ||
| actualFee2 := packets[0].PacketFees[1].Fee |
There was a problem hiding this comment.
maybe we can add an assertion that s.Require().Len(packets[0].PacketFees, 2) ?
e2e/fee_middleware_test.go
Outdated
Comment on lines
717
to
727
| actualBalance1, err := s.GetChainANativeBalance(ctx, chainAWallet1) | ||
| s.Require().NoError(err) | ||
|
|
||
| expected1 := testvalues.StartingTokenAmount - walletAmount1.Amount - testFee.Total().AmountOf(chainADenom).Int64() | ||
| s.Require().Equal(expected1, actualBalance1) | ||
|
|
||
| actualBalance2, err := s.GetChainANativeBalance(ctx, chainAWallet2) | ||
| s.Require().NoError(err) | ||
|
|
||
| expected2 := testvalues.StartingTokenAmount - testFee.Total().AmountOf(chainADenom).Int64() | ||
| s.Require().Equal(expected2, actualBalance2) |
There was a problem hiding this comment.
it might be worth splitting these up into two separate subtests, in the output of a test failure we would need to rely on line number to know which balance was incorrect.
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes: #1684
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes