Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: renaming ica migrations handler pkg version #2355

Merged
merged 4 commits into from
Sep 26, 2022

Conversation

damiannolan
Copy link
Member

Description

  • Renaming pkg version for interchain-accounts migration handler

closes: #XXXX


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@damiannolan damiannolan enabled auto-merge (squash) September 26, 2022 08:02
@codecov-commenter
Copy link

codecov-commenter commented Sep 26, 2022

Codecov Report

Merging #2355 (7cb1866) into main (b97729d) will increase coverage by 0.02%.
The diff coverage is 78.26%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2355      +/-   ##
==========================================
+ Coverage   79.54%   79.56%   +0.02%     
==========================================
  Files         175      175              
  Lines       12069    12134      +65     
==========================================
+ Hits         9600     9655      +55     
- Misses       2045     2050       +5     
- Partials      424      429       +5     
Impacted Files Coverage Δ
...27-interchain-accounts/controller/keeper/events.go 0.00% <ø> (ø)
...nterchain-accounts/controller/keeper/grpc_query.go 100.00% <ø> (ø)
...27-interchain-accounts/controller/keeper/params.go 100.00% <ø> (ø)
...in-accounts/controller/migrations/v6/migrations.go 89.65% <ø> (ø)
...ps/27-interchain-accounts/controller/types/msgs.go 92.30% <ø> (ø)
...ps/27-interchain-accounts/genesis/types/genesis.go 0.00% <ø> (ø)
...les/apps/27-interchain-accounts/host/ibc_module.go 95.00% <ø> (ø)
.../apps/27-interchain-accounts/host/keeper/events.go 0.00% <ø> (ø)
...apps/27-interchain-accounts/host/keeper/genesis.go 89.47% <ø> (ø)
...s/27-interchain-accounts/host/keeper/grpc_query.go 100.00% <ø> (ø)
... and 114 more

@damiannolan damiannolan merged commit 1dca3b0 into main Sep 26, 2022
@damiannolan damiannolan deleted the damian/rename-migrations-ica branch September 26, 2022 08:42
mergify bot pushed a commit that referenced this pull request Sep 26, 2022
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
(cherry picked from commit 1dca3b0)

# Conflicts:
#	modules/apps/27-interchain-accounts/controller/migrations/v6/migrations_test.go
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants