-
Notifications
You must be signed in to change notification settings - Fork 629
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
e2e: adding simd controller msg server tests #2572
Conversation
…ibc-go into damian/e2e-ics27-controller-simd
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job! 💚 All the workflow changes look good to me. Happy to get this merged once we've confirmed that all the tests pass when manually triggering them from this branch.
🥇
I just spotted the incorrect struct was embedded in the |
Description
The existing e2e tests for ics27 rely on the
intertx
module andicad
binary.With the addition of the controller
MsgServer
we should also cover that execution path, which can be done usingsimd
.MsgServer
intertx
tests to separate filesI have created an issue below to track legacy code which can be removed when
ibc-go/v5
reaches end-of-life.Please feel free to add anything to this which is necessary.
Manual
icad
workflow runs using the newInterTxTestSuite
andIncentivizedInterTxTestSuite
:Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/
) or specification (x/<module>/spec/
)godoc
comments.Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorerCodecov Report
in the comment section below once CI passes