Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ica: owner address is not always bech32 address #2583

Closed
3 tasks
charleenfei opened this issue Oct 25, 2022 · 0 comments · Fixed by #2601
Closed
3 tasks

ica: owner address is not always bech32 address #2583

charleenfei opened this issue Oct 25, 2022 · 0 comments · Fixed by #2601
Assignees
@charleenfei
Labels
27-interchain-accounts
Milestone
v6.0.0

Comments

@charleenfei
Copy link
Contributor

Summary

Problem Definition

ICA: owner address is checked as valid Bech32 address in ValidateBasic of MsgRegisterInterchainAccount and MsgSentTx. But, for example, Stride uses owner address that is not Bech32.

Proposal

remove check for owner address in ValidateBasic of MsgRegisterInterchainAccount and MsgSentTx.

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@charleenfei charleenfei self-assigned this Oct 25, 2022
@crodriguezvega crodriguezvega moved this to Todo in ibc-go Oct 25, 2022
@crodriguezvega crodriguezvega moved this from Todo to In progress in ibc-go Oct 25, 2022
@crodriguezvega crodriguezvega added this to the v6.0.0 milestone Oct 25, 2022
@charleenfei charleenfei mentioned this issue Oct 26, 2022
Merged
9 tasks
@charleenfei charleenfei moved this from In progress to In review in ibc-go Oct 26, 2022
Repository owner moved this from In review to Done in ibc-go Oct 31, 2022
@crodriguezvega crodriguezvega moved this from Todo to Done in ibc-go Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@charleenfei charleenfei

Labels
27-interchain-accounts
Projects
ibc-go
Status: Done 🥳
Milestone
v6.0.0
2 participants
@crodriguezvega @charleenfei