Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add documentation recommending contract keepers to defensively perform SendPacket validation in OnAcknowledgement and OnTimeout as well #4326

Closed
3 tasks
colin-axner opened this issue Aug 10, 2023 · 0 comments · Fixed by #4358
Closed
3 tasks

Add documentation recommending contract keepers to defensively perform SendPacket validation in OnAcknowledgement and OnTimeout as well #4326

colin-axner opened this issue Aug 10, 2023 · 0 comments · Fixed by #4358
Labels
audit Feedback from implementation audit callbacks middleware Issues for callbacks middleware docs Improvements or additions to documentation
Milestone
callbacks/v1.0.0

Comments

@colin-axner
Copy link
Contributor

Summary

Add documentation recommending contract keepers to defensively perform SendPacket validation in OnAcknowledgement and OnTimeout as well. This is to defend against chain's accidentally miss wiring their app.go (this is feasible given the subtle complexity to wiring an IBC stack)

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@colin-axner colin-axner added docs Improvements or additions to documentation audit Feedback from implementation audit callbacks middleware Issues for callbacks middleware labels Aug 10, 2023
@crodriguezvega crodriguezvega added this to the callbacks/v1.0.0 milestone Aug 14, 2023
@srdtrk srdtrk mentioned this issue Aug 16, 2023
Merged
9 tasks
@DimitrisJim DimitrisJim moved this to In review in ibc-go Aug 16, 2023
@github-project-automation github-project-automation bot moved this from In review to Done in ibc-go Aug 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
audit Feedback from implementation audit callbacks middleware Issues for callbacks middleware docs Improvements or additions to documentation
Projects
ibc-go
Archived in project
Milestone
callbacks/v1.0.0
Development

Successfully merging a pull request may close this issue.

docs(callbacks): added godocs for defensive send packet validation cosmos/ibc-go
2 participants
@crodriguezvega @colin-axner