Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move ICS4Wrappers from keepers to IBCModule implementations #4427

Open
3 tasks
colin-axner opened this issue Aug 22, 2023 · 0 comments
Open
3 tasks

Move ICS4Wrappers from keepers to IBCModule implementations #4427

colin-axner opened this issue Aug 22, 2023 · 0 comments
Labels
needs discussion Issues that need discussion before they can be worked on type: refactor Architecture, code or CI improvements that may or may not tackle technical debt.
Milestone

Comments

@colin-axner
Copy link
Contributor

colin-axner commented Aug 22, 2023

Summary

Currently, many of the keepers for IBC modules hold the ICS4Wrapper (upward calling in IBC stack). The ICS4Wrapper reference should be held by the IBCModule implementation itself

Problem Definition

An SDK chain declares only 1 keeper per application, but defines many IBC modules (potentially 1 per stack). It should be possible for different instances of the same IBC module to reference different ics4wrappers

Proposal

Move ics4wrappers to IBCModule implementations. Otherwise it would not be possible to do the following:

// transfer -> fee -> channel
// ica controller -> fee -> extra module -> channel

As the ics4wrapper is on the fee keeper which is shared between the 2 stacks despite having separate instances of fee.IBCModule

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@colin-axner colin-axner added needs discussion Issues that need discussion before they can be worked on type: refactor Architecture, code or CI improvements that may or may not tackle technical debt. labels Aug 22, 2023
@crodriguezvega crodriguezvega added this to the v10.0.0 milestone Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs discussion Issues that need discussion before they can be worked on type: refactor Architecture, code or CI improvements that may or may not tackle technical debt.
Projects
Status: No status
Development

Successfully merging a pull request may close this issue.

2 participants