Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

helper function to parse proposalID from events #4809

Closed
charleenfei opened this issue Oct 4, 2023 · 3 comments
Closed

helper function to parse proposalID from events #4809

charleenfei opened this issue Oct 4, 2023 · 3 comments
Assignees
@ThanhNhann
Labels
good first issue Good for newcomers testing Testing package and unit/integration tests type: code hygiene Clean up code but without changing functionality or interfaces

Comments

@charleenfei
Copy link
Contributor

charleenfei commented Oct 4, 2023 •
edited by crodriguezvega
Loading

Should we encapsulate this code in a helper function here, like we have for ParseClientIDFromEvents and other functions?

Originally posted by @crodriguezvega in #4773 (comment)

Add ParseProposalIDFromEvents utility function to the testing pkg.

we could sweep this under a ibctesting.ParseProposalIDFromEvents() func but can be a future improvement 👍

Originally posted by @damiannolan in #4773 (comment)
@crodriguezvega crodriguezvega added type: code hygiene Clean up code but without changing functionality or interfaces good first issue Good for newcomers labels Oct 4, 2023
@colin-axner colin-axner mentioned this issue Oct 5, 2023
Merged
9 tasks
@crodriguezvega crodriguezvega mentioned this issue Oct 5, 2023
Closed
@crodriguezvega crodriguezvega added the testing Testing package and unit/integration tests label Oct 5, 2023
@ThanhNhann
Copy link
Contributor

Can I handle this issue?

@damiannolan
Copy link
Member

Sure thing, I can assign you! Thanks very much @ThanhNhann

@ThanhNhann ThanhNhann mentioned this issue Oct 25, 2023
Merged
9 tasks
@damiannolan
Copy link
Member

closed by #4942

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ThanhNhann ThanhNhann

Labels
good first issue Good for newcomers testing Testing package and unit/integration tests type: code hygiene Clean up code but without changing functionality or interfaces
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@damiannolan @crodriguezvega @charleenfei @ThanhNhann