Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for UpdateChannelParams #5479

Closed
crodriguezvega opened this issue Dec 21, 2023 · 2 comments · Fixed by #5494
Closed

Add tests for UpdateChannelParams #5479

crodriguezvega opened this issue Dec 21, 2023 · 2 comments · Fixed by #5494
Assignees
@MukulKolpe
Labels
04-channel good first issue Good for newcomers

Comments

@crodriguezvega
Copy link
Contributor

crodriguezvega commented Dec 21, 2023 •
edited
Loading

Add tests for UpdateChannelParams. Should be similar as the tests for UpdateConnectionParams.

I think we are missing a test?

Originally posted by @colin-axner in #1613 (comment)
@MukulKolpe
Copy link
Contributor

Hey @crodriguezvega, can I work on this issue?

@crodriguezvega
Copy link
Contributor Author

Yes, thank you, @MukulKolpe!

@MukulKolpe MukulKolpe mentioned this issue Dec 23, 2023
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MukulKolpe MukulKolpe

Labels
04-channel good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: added tests for UpdateChannelParams MukulKolpe/ibc-go
2 participants
@crodriguezvega @MukulKolpe