Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow channel version to change in icahost #5605

Closed
3 tasks
Tracked by #3996
srdtrk opened this issue Jan 15, 2024 · 1 comment
Closed
3 tasks
Tracked by #3996

Allow channel version to change in icahost #5605

srdtrk opened this issue Jan 15, 2024 · 1 comment
Assignees
Labels
27-interchain-accounts change: state machine breaking Issues or PRs that break consensus (need to be released in at least a new minor version)

Comments

@srdtrk
Copy link
Member

srdtrk commented Jan 15, 2024

Summary

This proposal aims to enhance the ICA channel reopening process by removing the consistency checks in channel ordering and version string from icahost only

Problem Definition

Our current approach to transitioning from ordered to unordered ICA channels uses channel upgradability. We are not allowed to change the channel parameters while reopening an ICA channel. This is to prevent unauthorized relayers from modifying the ICA channel without ICA owner's consent.

Proposal

We propose an approach where icahost is to accept changes in channel parameters upon reopening, while icacontroller maintains the right to reject these changes. This strategy offers two significant advantages:

  1. Flexibility for External Implementations: External icacontroller implementations, particularly those prohibiting unauthorized reopening, can seamlessly transition their channels. They can do so by simply reopening with altered parameters.
  2. Future-proofing icacontroller Enhancements: This change ensures that potential future enhancements to icacontroller, which might include provisions for reopening channels with new parameters, are not impeded by icahost restrictions.

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@srdtrk srdtrk added 27-interchain-accounts change: state machine breaking Issues or PRs that break consensus (need to be released in at least a new minor version) labels Jan 15, 2024
@srdtrk srdtrk self-assigned this Jan 16, 2024
@srdtrk
Copy link
Member Author

srdtrk commented Jan 16, 2024

closed by #5613

@srdtrk srdtrk closed this as completed Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
27-interchain-accounts change: state machine breaking Issues or PRs that break consensus (need to be released in at least a new minor version)
Projects
None yet
Development

No branches or pull requests

1 participant