Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up panics in ICS20-V2 conversion logic #6387

Closed
3 tasks
chatton opened this issue May 27, 2024 · 0 comments · Fixed by #6391
Closed
3 tasks

Clean up panics in ICS20-V2 conversion logic #6387

chatton opened this issue May 27, 2024 · 0 comments · Fixed by #6391
Assignees
@chatton
Labels
20-transfer
Milestone
ICS20 v2 (multi d...

Comments

@chatton
Copy link
Contributor

chatton commented May 27, 2024

Summary

Some panics were left in the ics20-v2 conversion logic from when it was a PoC. I propose that we remove these and replace them with errors.

Ref here and here.

Note: For the second one it's probably fine to leave as panic since it should be unreachable code.

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chatton chatton

Labels
20-transfer
Projects
ibc-go
Archived in project
Milestone
ICS20 v2 (multi denom) RC
Development

Successfully merging a pull request may close this issue.

Refactor panic to use return error cosmos/ibc-go
1 participant
@chatton