Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ICS4: recvPacket() should emit an event for already received packets on ordered channels #755

Closed
plafer opened this issue May 20, 2022 · 0 comments · Fixed by #844
Closed
Assignees
Labels
tao Transport, authentication, & ordering layer.

Comments

@plafer
Copy link
Contributor

plafer commented May 20, 2022

ICS4's recvPacket() currently aborts the transaction and emits no logs if the channel is ordered and the sequence number in the packet doesn't match the chain's nextSequenceRecv. However, ibc-go and ibc-rs emit an event and return a "no-op" error code, as introduced in this PR, when packet.sequence < nextSequenceRecv. This deviation from the standard was introduced to reduce fees to relayers.

I don't know if we want to consider the "no-op" error code an implementation detail; however, I believe we should at least have the standard emit an event when packet.sequence < nextSequenceRecv.

@crodriguezvega crodriguezvega added the tao Transport, authentication, & ordering layer. label Aug 16, 2022
@crodriguezvega crodriguezvega moved this to Todo in IBC specs Aug 16, 2022
@crodriguezvega crodriguezvega self-assigned this Aug 16, 2022
@crodriguezvega crodriguezvega moved this from Todo to In review in IBC specs Oct 1, 2022
Repository owner moved this from In review to Done in IBC specs Oct 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tao Transport, authentication, & ordering layer.
Projects
Status: Backlog
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants