Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup x/ccv/types #1213

Closed
shaspitz opened this issue Aug 18, 2023 · 1 comment · Fixed by #1350
Closed

Cleanup x/ccv/types #1213

shaspitz opened this issue Aug 18, 2023 · 1 comment · Fixed by #1350
Assignees
@bermuell
Labels
good first issue Good for newcomers S: KTLO Keeping the lights on: Keeping the current product operational (bugs, troubleshooting, deps updates) type: refactoring Code refactoring

Comments

@shaspitz
Copy link
Contributor

shaspitz commented Aug 18, 2023 •
edited
Loading

Problem

#1071 has helped illuminate opportunities for cleanup of x/ccv/types. They will be outlined below.

Closing criteria

  • Remove unreferenced vars and funcs in x/ccv/codec.go.
  • in x/ccv/errors.go, move errors specific to only consumer/provider to their appropriate errors.go file.
  • Ditto for events.go
  • Split out expected_keepers.go to live in the provider/consumer modules separately, this is best practice for sdk modules.
  • Vaguely named consumer structs #1206

Problem details
@shaspitz shaspitz added status: waiting-triage This issue/PR has not yet been triaged by the team. good first issue Good for newcomers labels Aug 18, 2023
@mpoke mpoke added type: refactoring Code refactoring and removed status: waiting-triage This issue/PR has not yet been triaged by the team. labels Aug 21, 2023
@mpoke mpoke added the S: KTLO Keeping the lights on: Keeping the current product operational (bugs, troubleshooting, deps updates) label Sep 14, 2023
@bermuell bermuell self-assigned this Sep 25, 2023
@MSalopek
Copy link
Contributor

MSalopek commented Oct 10, 2023 •
edited
Loading

Split out expected_keepers.go to live in the provider/consumer modules separately, this is best practice for sdk modules.

This should be it's own separate issue. Changing it now will break upstream work on upgrading versions etc.

@bermuell bermuell mentioned this issue Oct 11, 2023
Merged
21 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bermuell bermuell

Labels
good first issue Good for newcomers S: KTLO Keeping the lights on: Keeping the current product operational (bugs, troubleshooting, deps updates) type: refactoring Code refactoring
Projects
Cosmos Hub
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: cleanup ccv types cosmos/interchain-security
4 participants
@mpoke @MSalopek @bermuell @shaspitz