You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
#393 made this parameter an sdk "param". But it has always existed as an integer, acting as a denominator to calculate trusting periods. This param makes more sense as a fraction, but will require a way to encode a numerator and denominator into json on genesis.
We could try using ibctmtypes.Fraction or two separate params for numerator and denominator
shaspitz
changed the title
TrustingPeriodFraction parameter is not a fraction, it should be a fraction
TrustingPeriodFraction should be a fraction
Oct 20, 2022
Problem
#393 made this parameter an sdk "param". But it has always existed as an integer, acting as a denominator to calculate trusting periods. This param makes more sense as a fraction, but will require a way to encode a numerator and denominator into json on genesis.
We could try using
ibctmtypes.Fraction
or two separate params for numerator and denominatorRelated to this, the default for the new fraction should be 2/3 per https://github.com/cosmos/ibc-go/blob/main/docs/architecture/adr-026-ibc-client-recovery-mechanisms.md, i.e.,
Closing criteria
Make this param a fraction, be able to encode that fraction in json, set new recommended default
TODOs
The text was updated successfully, but these errors were encountered: