Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cleanup interchain_security/proto #751

Closed
2 tasks done
MSalopek opened this issue Mar 2, 2023 · 0 comments · Fixed by #752
Closed
2 tasks done

cleanup interchain_security/proto #751

MSalopek opened this issue Mar 2, 2023 · 0 comments · Fixed by #752
Assignees
@MSalopek
Labels
scope: UI Addressing UX changes and improvements to user interface type: tech-debt Slows down development in the long run
Milestone
ICS v1.0.1

Comments

@MSalopek
Copy link
Contributor

MSalopek commented Mar 2, 2023

Problem

During testing it was discovered that we were missing some third_party proto definitions which made it impossible query grpc endpoints using grpcurl, grpcui and other similar tools.

Besides that, the interchain_security/proto/ccv contains unused files: query.proto and ccv.proto.

Closing criteria

Remove unused files.
Add missing third_party dependencies

TODOs

  • Labels have been added for issue
  • Issue has been added to the ICS project
@MSalopek MSalopek added type: tech-debt Slows down development in the long run scope: UI Addressing UX changes and improvements to user interface labels Mar 2, 2023
@MSalopek MSalopek added this to the ICS v1.0.1 milestone Mar 2, 2023
@MSalopek MSalopek self-assigned this Mar 2, 2023
@MSalopek MSalopek mentioned this issue Mar 2, 2023
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MSalopek MSalopek

Labels
scope: UI Addressing UX changes and improvements to user interface type: tech-debt Slows down development in the long run
Projects
Cosmos Hub
Status: ✅ Done
Milestone
ICS v1.0.1
Development

Successfully merging a pull request may close this issue.

update protos; fix missing proto dependencies cosmos/interchain-security
1 participant
@MSalopek