Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release/v1.2.x #870

Closed
faddat opened this issue Apr 21, 2023 · 4 comments
Closed

release/v1.2.x #870

faddat opened this issue Apr 21, 2023 · 4 comments
Assignees

Comments

@faddat
Copy link
Contributor

faddat commented Apr 21, 2023

Hi, I'm looking to make a pr to backport the spm removal to the v1.2.x branch, but currently we don't have a branch release/v1.2.x

could someone please make one?

thanks

@faddat faddat mentioned this issue Apr 21, 2023
@mpoke
Copy link
Contributor

mpoke commented Apr 22, 2023

I'm looking to make a pr to backport the spm removal to the v1.2.x branch

@faddat Could you please give more context for this issue? What is the problem that you're trying to address? Thanks.

@faddat
Copy link
Contributor Author

faddat commented Apr 22, 2023

It is linked to above, but here it is again:

Currently our precious Gaia is importing spm. We must ensure that does not occur. Since gaia's main is on v1.2.0 right now, it makes sense to cherry pick the spm removal into v1.2.x and cut a v1.2.1 so that gaia no longer imports spm.

@mpoke
Copy link
Contributor

mpoke commented Apr 24, 2023

Currently our precious Gaia is importing spm. We must ensure that does not occur.

Gaia itself doesn’t use spm, it is just a build dependency of ICS v1.1.0 https://github.com/cosmos/gaia/blob/7c40c15a08bbb19ca66207f6c4521f6f550ad67f/go.mod#L265.

Since gaia's main is on v1.2.0 right now, it makes sense to cherry pick the spm removal into v1.2.x and cut a v1.2.1 so that gaia no longer imports spm.

Note that Gaia currently imports ICS v.1.1.0 https://github.com/cosmos/gaia/blob/7c40c15a08bbb19ca66207f6c4521f6f550ad67f/go.mod#L9 and not v1.2.0. The v1.2.0 release contains changes for the consumer module (e.g., the soft-opt out needed by Neutron). See https://github.com/cosmos/interchain-security/releases/tag/v1.2.0. Also note that v1.2.0 contains multiple changes that need to be properly tested before adding them to Gaia.

We’ll cut releases for ICS v1.1.1 and v1.2.1 with SPM removed. However, we cannot use v1.2.1 on Gaia until it’s properly tested.

@faddat
Copy link
Contributor Author

faddat commented Apr 28, 2023

That's wonderful, thank you. This is safer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

No branches or pull requests

3 participants