Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remember the last network selected #3063

Closed
faboweb opened this issue Oct 29, 2019 · 8 comments · Fixed by #3150
Closed

Remember the last network selected #3063

faboweb opened this issue Oct 29, 2019 · 8 comments · Fixed by #3150
Assignees

Comments

@faboweb
Copy link
Collaborator

faboweb commented Oct 29, 2019

Is your feature request related to a problem? Please describe.

When I start Lunie I want to see the same network I last selected.

Describe the solution you'd like

The last selected network should be stored in localStorage.
On boot the last selected network should be loaded from localStorage. The according network config should be loaded from the API (endpoints could have been changed).

Describe alternatives you've considered

Store this remote in a user table maybe. But it's too early for this.

Additional context

@faboweb
Copy link
Collaborator Author

faboweb commented Oct 30, 2019

@atharva3010 interesting to you?

@atharva3010
Copy link

atharva3010 commented Oct 30, 2019

Yeah! We can use Vuex-persist, is that what we are aiming at @faboweb ?

@faboweb
Copy link
Collaborator Author

faboweb commented Oct 30, 2019

I was aiming at just using localStorage without any plugin for simplicity.
But vuex-persist could also be interesting! Depends if we can filter out security critical information.

@atharva3010
Copy link

Ah I see! I would be comfortable either way. @faboweb just let me know what would be best suited for this use case.

@faboweb
Copy link
Collaborator Author

faboweb commented Oct 30, 2019

Might be interesting to replace all our "localStorage" calls with vuex-persist. But I don't know if there are any problems following this like react to existence and non-existence of entries. Are you interested in playing around with it?

@atharva3010
Copy link

I am interested in playing around with this. Is this high priority? I am amidst my end term examinations, I can perhaps check it on Sunday, sounds good? If it’s high priority, you can assign someone else :)

@faboweb
Copy link
Collaborator Author

faboweb commented Oct 31, 2019

Not high priority! :) Good luck with your exams!

@atharva3010
Copy link

Thank you sir! @faboweb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants