Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error control in PageProposal #3093

Closed
mariopino opened this issue Nov 6, 2019 · 0 comments · Fixed by #3243
Closed

Error control in PageProposal #3093

mariopino opened this issue Nov 6, 2019 · 0 comments · Fixed by #3243
Assignees
@mariopino
Labels
bug 🐛 issues related to unhandled errors in the code that need to be fixed

Comments

@mariopino
Copy link
Contributor

Describe the bug

We can make a better error control in PageProposal, for example if we request a non existent proposal like:

http://localhost:9080/proposals/999

Actually we are getting this error:

Aw shucks!
Even though you're connected a full node, we can't display this data for you right now. Please try again later or file a bug report. Apologies!

Expected behavior

We should get a Proposal not found error or something like that.

Screenshots

image
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mariopino mariopino

Labels
bug 🐛 issues related to unhandled errors in the code that need to be fixed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve error control in PageProposal luniehq/lunie
2 participants
@faboweb @mariopino